On Tue, May 23, 2023 at 02:30:37PM +0530, Chandan Babu R wrote:
> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
> ---
> include/xfs_metadump.h | 32 ++++++++++++++++++++++++++++++++
> 1 file changed, 32 insertions(+)
>
> diff --git a/include/xfs_metadump.h b/include/xfs_metadump.h
> index a4dca25cb..1d8d7008c 100644
> --- a/include/xfs_metadump.h
> +++ b/include/xfs_metadump.h
> @@ -8,7 +8,9 @@
> #define _XFS_METADUMP_H_
>
> #define XFS_MD_MAGIC_V1 0x5846534d /* 'XFSM' */
> +#define XFS_MD_MAGIC_V2 0x584D4432 /* 'XMD2' */
>
> +/* Metadump v1 */
> typedef struct xfs_metablock {
> __be32 mb_magic;
> __be16 mb_count;
> @@ -23,4 +25,34 @@ typedef struct xfs_metablock {
> #define XFS_METADUMP_FULLBLOCKS (1 << 2)
> #define XFS_METADUMP_DIRTYLOG (1 << 3)
>
> +/* Metadump v2 */
> +struct xfs_metadump_header {
> + __be32 xmh_magic;
> + __be32 xmh_version;
> + __be32 xmh_compat_flags;
> + __be32 xmh_incompat_flags;
> + __be64 xmh_reserved;
__be32 xmh_crc; ?
Otherwise there's nothing to check for bitflips in the index blocks
themselves.
> +} __packed;
Does an array of xfs_meta_extent come immediately after
xfs_metadump_header, or do they go in a separate block after the header?
How big is the index block supposed to be?
> +
> +#define XFS_MD2_INCOMPAT_OBFUSCATED (1 << 0)
> +#define XFS_MD2_INCOMPAT_FULLBLOCKS (1 << 1)
> +#define XFS_MD2_INCOMPAT_DIRTYLOG (1 << 2)
Should the header declare when some of the xfs_meta_extents will have
XME_ADDR_LOG_DEVICE set?
> +
> +struct xfs_meta_extent {
> + /*
Tabs not spaces.
> + * Lowest 54 bits are used to store 512 byte addresses.
> + * Next 2 bits is used for indicating the device.
> + * 00 - Data device
> + * 01 - External log
So if you were to (say) add the realtime device, would that be bit 56,
or would you define 0xC0000000000000 (aka DATA|LOG) to mean realtime?
> + */
> + __be64 xme_addr;
> + /* In units of 512 byte blocks */
> + __be32 xme_len;
> +} __packed;
> +
> +#define XME_ADDR_DATA_DEVICE (1UL << 54)
> +#define XME_ADDR_LOG_DEVICE (1UL << 55)
1ULL, because "UL" means unsigned long, which is 32-bits on i386.
--D
> +
> +#define XME_ADDR_DEVICE_MASK (~(XME_ADDR_DATA_DEVICE | XME_ADDR_LOG_DEVICE))
> +
> #endif /* _XFS_METADUMP_H_ */
> --
> 2.39.1
>
