On Tue, May 23, 2023 at 02:30:28PM +0530, Chandan Babu R wrote:
> The device size verification code should be writing XFS_MAX_SECTORSIZE bytes
> to the end of the device rather than "sizeof(char *) * XFS_MAX_SECTORSIZE"
> bytes.
>
> Signed-off-by: Chandan Babu R <chandan.babu@xxxxxxxxxx>
Yikes.
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> mdrestore/xfs_mdrestore.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/mdrestore/xfs_mdrestore.c b/mdrestore/xfs_mdrestore.c
> index 7c1a66c40..333282ed2 100644
> --- a/mdrestore/xfs_mdrestore.c
> +++ b/mdrestore/xfs_mdrestore.c
> @@ -115,7 +115,7 @@ perform_restore(
> } else {
> /* ensure device is sufficiently large enough */
>
> - char *lb[XFS_MAX_SECTORSIZE] = { NULL };
> + char lb[XFS_MAX_SECTORSIZE] = { 0 };
> off64_t off;
>
> off = sb.sb_dblocks * sb.sb_blocksize - sizeof(lb);
> --
> 2.39.1
>
