On Fri, May 19, 2023 at 11:35:08AM +0200, Christoph Hellwig wrote: > Hi all, > > this series cleans up some of the generic write helper calling > conventions and the page cache writeback / invalidation for > direct I/O. This is a spinoff from the no-bufferhead kernel > project, for while we'll want to an use iomap based buffered > write path in the block layer. Heh. For patches 3 and 8, I wonder if you could just get rid of current->backing_dev_info? For patches 2, 4-6, and 10: Acked-by: Darrick J. Wong <djwong@xxxxxxxxxx> For patches 1, 7, and 9: Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> The fuse patches I have no idea about. :/ --D > diffstat: > block/fops.c | 18 ---- > fs/ceph/file.c | 6 - > fs/direct-io.c | 10 -- > fs/ext4/file.c | 12 --- > fs/f2fs/file.c | 3 > fs/fuse/file.c | 47 ++---------- > fs/gfs2/file.c | 7 - > fs/iomap/buffered-io.c | 12 ++- > fs/iomap/direct-io.c | 88 ++++++++-------------- > fs/libfs.c | 36 +++++++++ > fs/nfs/file.c | 6 - > fs/xfs/xfs_file.c | 7 - > fs/zonefs/file.c | 4 - > include/linux/fs.h | 7 - > include/linux/pagemap.h | 4 + > mm/filemap.c | 184 +++++++++++++++++++++--------------------------- > 16 files changed, 190 insertions(+), 261 deletions(-)