Christoph Hellwig <hch@xxxxxxxxxxxxx> writes: >> + if (iop) { >> + spin_lock_irqsave(&iop->uptodate_lock, flags); >> + bitmap_set(iop->uptodate, first_blk, nr_blks); >> + if (bitmap_full(iop->uptodate, >> + i_blocks_per_folio(inode, folio))) >> + folio_mark_uptodate(folio); >> + spin_unlock_irqrestore(&iop->uptodate_lock, flags); >> + } else { >> + folio_mark_uptodate(folio); >> + } > > If we did a: > > if (!iop) { > folio_mark_uptodate(folio); > return; > } > > we can remove a leel of identation and keep thing a bit simpler. > But I can live with either style. Yup, it pleases my eyes too!! I will change it. -ritesh