Re: [PATCH RFC 16/16] nvme: Support atomic writes

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH RFC 16/16] nvme: Support atomic writes
From: Bart Van Assche <bvanassche@xxxxxxx>
Date: Wed, 3 May 2023 11:49:56 -0700
Cc: linux-block@xxxxxxxxxxxxxxx, linux-kernel@xxxxxxxxxxxxxxx, linux-nvme@xxxxxxxxxxxxxxxxxxx, linux-scsi@xxxxxxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx, linux-fsdevel@xxxxxxxxxxxxxxx, linux-security-module@xxxxxxxxxxxxxxx, paul@xxxxxxxxxxxxxx, jmorris@xxxxxxxxx, serge@xxxxxxxxxx, Alan Adamson <alan.adamson@xxxxxxxxxx>
In-reply-to: <20230503183821.1473305-17-john.g.garry@oracle.com>
References: <20230503183821.1473305-1-john.g.garry@oracle.com> <20230503183821.1473305-17-john.g.garry@oracle.com>
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1

On 5/3/23 11:38, John Garry wrote:

+			if (!(boundary & (boundary - 1))) {


Please use is_power_of_2() instead of open-coding it.

Thanks,

Bart.

Follow-Ups:
- Re: [PATCH RFC 16/16] nvme: Support atomic writes
  - From: John Garry

References:
- [PATCH RFC 00/16] block atomic writes
  - From: John Garry
- [PATCH RFC 16/16] nvme: Support atomic writes
  - From: John Garry

Prev by Date: Re: [PATCH RFC 14/16] scsi: sd: Add WRITE_ATOMIC_16 support
Next by Date: Re: [PATCH RFC 06/16] block: Limit atomic writes according to bio and queue limits
Previous by thread: [PATCH RFC 16/16] nvme: Support atomic writes
Next by thread: Re: [PATCH RFC 16/16] nvme: Support atomic writes
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux