Re: [PATCH 4/4] xfs: don't allocate into the data fork for an unshare request

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Apr 27, 2023 at 03:49:16PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> For an unshare request, we only have to take action if the data fork has
> a shared mapping.  We don't care if someone else set up a cow operation.
> If we find nothing in the data fork, return a hole to avoid allocating
> space.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  fs/xfs/xfs_iomap.c |    5 +++--
>  1 file changed, 3 insertions(+), 2 deletions(-)

Looks ok, but I'm unsure of what bad behaviour this might be fixing.
Did you just notice this, or does it fix some kind of test failure?

-Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux