On Wed, Apr 05, 2023 at 05:02:59PM -0700, Darrick J. Wong wrote: > - if (tolower(args->name[i]) != tolower(name[i])) > + if (xfs_ascii_ci_xfrm(args->name[i]) != xfs_ascii_ci_xfrm(name[i])) Please avoid the overly long line name here. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>