On Tue, Apr 4, 2023 at 1:51 PM Darrick J. Wong <djwong@xxxxxxxxxx> wrote:
>
> Wrong. I'm well aware that userspace tolower and kernel tolower are
> *NOT* the same thing. I'm trying to **STOP USING** tolower in XFS.
Ok, so you're not actually talking about "userspace tolower()".
You are actually talking about just the same function in xfstools and
the kernel, and neither is really "tolower()", but is a
"xfs_hashprep()".
Fair enough. That works. I still think it should be made to be
US-ASCII only, in order to not have any strange oddities.
Do you really have to support that "pseudo-latin1" thing? If it's
literally just a "xfs_hashprep()" function, and you arbitrarily pick
one random function, why make it be a known-broken one?
Linus
