From: Darrick J. Wong <djwong@xxxxxxxxxx>
Reduce the indentation in this function by flattening the nested if
statements. We're going to add more code later to this function later,
hence the early cleanup. No functional changes.
Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
---
fs/xfs/libxfs/xfs_attr.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
index 86672061c99e..996ef24482e1 100644
--- a/fs/xfs/libxfs/xfs_attr.c
+++ b/fs/xfs/libxfs/xfs_attr.c
@@ -422,17 +422,17 @@ xfs_attr_complete_op(
bool do_replace = args->op_flags & XFS_DA_OP_REPLACE;
args->op_flags &= ~XFS_DA_OP_REPLACE;
- if (do_replace) {
- args->attr_filter &= ~XFS_ATTR_INCOMPLETE;
- if (args->new_namelen > 0) {
- args->name = args->new_name;
- args->namelen = args->new_namelen;
- args->hashval = xfs_da_hashname(args->name,
- args->namelen);
- }
+ if (!do_replace)
+ return XFS_DAS_DONE;
+
+ args->attr_filter &= ~XFS_ATTR_INCOMPLETE;
+ if (args->new_namelen == 0)
return replace_state;
- }
- return XFS_DAS_DONE;
+
+ args->name = args->new_name;
+ args->namelen = args->new_namelen;
+ args->hashval = xfs_da_hashname(args->name, args->namelen);
+ return replace_state;
}
static int
