On Fri, Feb 24, 2023 at 01:34:01PM +0530, shrikanth hegde wrote:
>
> >>> ...that trips when rm tries to remove a file, which means that the call
> >>> stack is
> >>>
> >>> xfs_remove -> xfs_iunlink -> xfs_iunlink_insert_inode ->
> >>> xfs_iunlink_update_backref -> xfs_iunlink_lookup <kaboom>
> >>>
> >>> It looks as though "rm foo" unlinked foo from the directory and was
> >>> trying to insert it at the head of one of the unlinked lists in the AGI
> >>> buffer. The AGI claims that the list points to an ondisk inode, so the
> >>> iunlink code tries to find the incore inode to update the incore list,
> >>> fails to find an incore inode, and this is the result...
> >>
> >> This seems to happen for rename as well. i.e xfs_rename.
> >> Does rename path calls rm first, and then create?
> >
> > Effectively, yes. A "mv a b" will unlink b, and that calls the same
> > internal unlink code as an unlink syscall.
> >
> >>>>
> >>>>
> >>>> we did a git bisect between 5.17 and 6.0. Bisect points to commit 04755d2e5821
> >>>> as the bad commit.
> >>>> Short description of commit:
> >>>> commit 04755d2e5821b3afbaadd09fe5df58d04de36484 (refs/bisect/bad)
> >>>> Author: Dave Chinner <dchinner@xxxxxxxxxx>
> >>>> Date: Thu Jul 14 11:42:39 2022 +1000
> >>>>
> >>>> xfs: refactor xlog_recover_process_iunlinks()
> >>>
> >>> ...which was in the middle of the series that reworked thev mount time
> >>> iunlink clearing. Oddly, I don't spot any obvious errors in /that/
> >>> patch that didn't already exist. But this does make me wonder, does
> >>> xfs_repair -n have anything to say about unlinked or orphaned inodes?
> >>>
> >>> The runtime code expects that every ondisk inode in an iunlink chain has
> >>> an incore inode that is linked (via i_{next,prev}_unlinked) to the other
> >>> incore inodes in that same chain. If this requirement is not met, then
> >>> the WARNings you see will trip, and the fs shuts down.
> >>>
> >>> My hypothesis here is that one of the AGs has an unprocessed unlinked
> >>> list. At mount time, the ondisk log was clean, so mount time log
> >>> recovery didn't invoke xlog_recover_process_iunlinks, and the list was
> >>> not cleared. The mount code does not construct the incore unlinked list
> >>> from an existing ondisk iunlink list, hence the WARNing. Prior to 5.17,
> >>> we only manipulated the ondisk unlink list, and the code never noticed
> >>> or cared if there were mystery inodes in the list that never went away.
> >>>
> >>> (Obviously, if something blew up earlier in dmesg, that would be
> >>> relevant here.)
> >>>
> >>> It's possible that we could end up in this situation (clean log,
> >>> unlinked inodes) if a previous log recovery was only partially
> >>> successful at clearing the unlinked list, since all that code ignores
> >>> errors. If that happens, we ... succeed at mounting and clean the log.
> >>>
> >>> If you're willing to patch your kernels, it would be interesting
> >>> to printk if the xfs_read_agi or the xlog_recover_iunlink_bucket calls
> >>> in xlog_recover_iunlink_ag returns an error code. It might be too late
> >>
> >> We can try. Please provide the Patch.
> >>
> >>> to capture that, hence my suggestion of seeing if xfs_repair -n will
> >>> tell us anything else.
> >>>
> >>
> >> Could you please clarify? We should run xfs_repair -n from 5.17-rc2 kernel?
> >
> > Whatever xfs_repair is installed on the system should suffice to report
> > an unlinked inode list and any other errors on the filesystem. That
> > evidence will guide us towards a kernel patch.
> >
> > --D
> >
>
> # xfs_info /
> meta-data=/dev/mapper/rhel_ltc--lp1-root isize=512 agcount=4, agsize=4183040 blks
> = sectsz=512 attr=2, projid32bit=1
> = crc=1 finobt=1, sparse=1, rmapbt=0
> = reflink=1 bigtime=0 inobtcount=0
> data = bsize=4096 blocks=16732160, imaxpct=25
> = sunit=0 swidth=0 blks
> naming =version 2 bsize=4096 ascii-ci=0, ftype=1
> log =internal log bsize=4096 blocks=8170, version=2
> = sectsz=512 sunit=0 blks, lazy-count=1
> realtime =none extsz=4096 blocks=0, rtextents=0
> #
> #
> # xfs_repair -n /
> xfs_repair: can't determine device size
xfs_repair takes a path to a block device.
--D
>
> >>
> >>> I've long thought that the iunlink recovery ought to complain loudly and
> >>> fail the mount if it can't clear all the unlinked files. Given the new
> >>> iunlink design, I think it's pretty much required now. The uglier piece
> >>> is that now we either (a) have to clear iunlinks at mount time
> >>> unconditionally as Eric has been saying for years; or (b) construct the
> >>> incore list at a convenient time so that the incore list always exists.
> >>>
> >>> Thanks for the detailed report!
> >>>
> >>> --D
> >>>
> >>>>
> >>>> Git bisect log:
> >>>> git bisect start
> >>>> # good: [26291c54e111ff6ba87a164d85d4a4e134b7315c] Linux 5.17-rc2
> >>>> git bisect good 26291c54e111ff6ba87a164d85d4a4e134b7315c
> >>>> # bad: [4fe89d07dcc2804c8b562f6c7896a45643d34b2f] Linux 6.0
> >>>> git bisect bad 4fe89d07dcc2804c8b562f6c7896a45643d34b2f
> >>>> # good: [d7227785e384d4422b3ca189aa5bf19f462337cc] Merge tag 'sound-5.19-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/tiwai/sound
> >>>> git bisect good d7227785e384d4422b3ca189aa5bf19f462337cc
> >>>> # good: [526942b8134cc34d25d27f95dfff98b8ce2f6fcd] Merge tag 'ata-5.20-rc1' of git://git.kernel.org/pub/scm/linux/kernel/git/dlemoal/libata
> >>>> git bisect good 526942b8134cc34d25d27f95dfff98b8ce2f6fcd
> >>>> # good: [328141e51e6fc79d21168bfd4e356dddc2ec7491] Merge tag 'mmc-v5.20' of git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc
> >>>> git bisect good 328141e51e6fc79d21168bfd4e356dddc2ec7491
> >>>> # bad: [eb555cb5b794f4e12a9897f3d46d5a72104cd4a7] Merge tag '5.20-rc-ksmbd-server-fixes' of git://git.samba.org/ksmbd
> >>>> git bisect bad eb555cb5b794f4e12a9897f3d46d5a72104cd4a7
> >>>> # bad: [f20c95b46b8fa3ad34b3ea2e134337f88591468b] Merge tag 'tpmdd-next-v5.20' of git://git.kernel.org/pub/scm/linux/kernel/git/jarkko/linux-tpmdd
> >>>> git bisect bad f20c95b46b8fa3ad34b3ea2e134337f88591468b
> >>>> # bad: [fad235ed4338749a66ddf32971d4042b9ef47f44] Merge tag 'arm-late-6.0' of git://git.kernel.org/pub/scm/linux/kernel/git/soc/soc
> >>>> git bisect bad fad235ed4338749a66ddf32971d4042b9ef47f44
> >>>> # good: [e495274793ea602415d050452088a496abcd9e6c] Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma
> >>>> git bisect good e495274793ea602415d050452088a496abcd9e6c
> >>>> # good: [9daee913dc8d15eb65e0ff560803ab1c28bb480b] Merge tag 'ext4_for_linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tytso/ext4
> >>>> git bisect good 9daee913dc8d15eb65e0ff560803ab1c28bb480b
> >>>> # bad: [29b1d469f3f6842ee4115f0b21f018fc44176468] Merge tag 'trace-rtla-v5.20' of git://git.kernel.org/pub/scm/linux/kernel/git/rostedt/linux-trace
> >>>> git bisect bad 29b1d469f3f6842ee4115f0b21f018fc44176468
> >>>> # good: [932b42c66cb5d0ca9800b128415b4ad6b1952b3e] xfs: replace XFS_IFORK_Q with a proper predicate function
> >>>> git bisect good 932b42c66cb5d0ca9800b128415b4ad6b1952b3e
> >>>> # bad: [35c5a09f5346e690df7ff2c9075853e340ee10b3] Merge tag 'xfs-buf-lockless-lookup-5.20' of git://git.kernel.org/pub/scm/linux/kernel/git/dgc/linux-xfs into xfs-5.20-mergeB
> >>>> git bisect bad 35c5a09f5346e690df7ff2c9075853e340ee10b3
> >>>> # bad: [fad743d7cd8bd92d03c09e71f29eace860f50415] xfs: add log item precommit operation
> >>>> git bisect bad fad743d7cd8bd92d03c09e71f29eace860f50415
> >>>> # bad: [04755d2e5821b3afbaadd09fe5df58d04de36484] xfs: refactor xlog_recover_process_iunlinks()
> >>>> git bisect bad 04755d2e5821b3afbaadd09fe5df58d04de36484
> >>>> # good: [a4454cd69c66bf3e3bbda352b049732f836fc6b2] xfs: factor the xfs_iunlink functions
> >>>> git bisect good a4454cd69c66bf3e3bbda352b049732f836fc6b2
> >>>> Bisecting: 0 revisions left to test after this (roughly 0 steps)
> >>>> [4fcc94d653270fcc7800dbaf3b11f78cb462b293] xfs: track the iunlink list pointer in the xfs_inode
> >>>>
> >>>>
> >>>> Please reach out, in case any more details are needed. sent with very limited
> >>>> knowledge of xfs system. these logs are from 5.19 kernel.
> >>>>
> >>>> # xfs_info /home
> >>>> meta-data=/dev/nvme0n1p1 isize=512 agcount=4, agsize=13107200 blks
> >>>> = sectsz=4096 attr=2, projid32bit=1
> >>>> = crc=1 finobt=1, sparse=1, rmapbt=0
> >>>> = reflink=1 bigtime=0 inobtcount=0
> >>>> data = bsize=4096 blocks=52428800, imaxpct=25
> >>>> = sunit=0 swidth=0 blks
> >>>> naming =version 2 bsize=4096 ascii-ci=0, ftype=1
> >>>> log =internal log bsize=4096 blocks=25600, version=2
> >>>> = sectsz=4096 sunit=1 blks, lazy-count=1
> >>>> realtime =none extsz=4096 blocks=0, rtextents=0
> >>>>
> >>>> # xfs_info -V
> >>>> xfs_info version 5.0.0
> >>>>
> >>>> # uname -a
> >>>> 5.19.0-rc2
