Re: [PATCH v10 2/3] fs: introduce super_drop_pagecache()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 





在 2023/2/21 5:25, Dave Chinner 写道:
On Fri, Feb 17, 2023 at 02:48:31PM +0000, Shiyang Ruan wrote:
xfs_notify_failure.c requires a method to invalidate all dax mappings.
drop_pagecache_sb() can do this but it is a static function and only
build with CONFIG_SYSCTL.  Now, move its implementation into super.c and
call it super_drop_pagecache().  Use its second argument as invalidator
so that we can choose which invalidate method to use.

Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>

I got no repsonse last time, so I'll just post a link to the
concerns I stated about this:

https://lore.kernel.org/linux-xfs/20230205215000.GT360264@xxxxxxxxxxxxxxxxxxx/

Please see patch 3. I changed the code: freeze the fs, then drop its caches.


--
Thanks,
Ruan.


-Dave.



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux