On Wed, Feb 08, 2023 at 09:02:58 PM +0200, Amir Goldstein wrote: > On Wed, Feb 8, 2023 at 7:52 PM Leah Rumancik <leah.rumancik@xxxxxxxxx> wrote: >> >> Hello again, >> >> Here is the next batch of backports for 5.15.y. Testing included >> 25 runs of auto group on 12 xfs configs. No regressions were seen. >> I checked xfs/538 was run without issue as this test was mentioned >> in 56486f307100. Also, from 86d40f1e49e9, I ran ran xfs/117 with >> XFS compiled as a module and TEST_FS_MODULE_REOLOAD set, but I was >> unable to reproduce the issue. > > Did you find any tests that started to pass or whose failure rate reduced? > > There are very few Fixes: annotations in these commits so it is hard for > me to assess if any of them are relevant/important/worth the effort/risk > to backport to 5.10. > > Unless I know of reproducible bugs in 5.10, I don't think I will invest > in backporting this series to 5.10. > Chandan, if you find any of these fixes relevant and important for 5.4 > let me know and I will make the effort to consider them for 5.10. Amir, Please find my observations listed below, Patch 1: Intent whiteouts was designed to overcome performance problems with delayed attributes feature. Hence this patch will not be needed for v5.4-LTS. Patch 2: This patch won't be needed since this memory leak is prevalent mostly when intent whiteouts are being used. Patch 3: IMHO this fix does not need to be back-ported since ondisk btree cycles are close to impossible to occur during regular operation of an XFS filesystem. Patch 4: This patch won't be needed since xfs_mount->m_features isn't present in v5.4 xfsprogs. Patch 5: I am not sure about this one. May be mkfs.xfs has always created V5 filesystems with the required V4 feature flags set and probably fuzzing is the only way we could modify a V5 filesystem to have some of the required V4 feature flags disabled. I don't think this patch needs to be backported if my assumptions are true. Patch 6: This patch does not need to be backported since this fixes a performance regression introduced by the third patch. Patch 7: I will want to backport this patch since it will prevent recovery-loop test execution from stalling. Patch 8: I think backporting XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTENT error tag to 5.4-LTS will be helpful since xfs/538 has revealed some important bugs. Patch 8 needs to backported after backporting patches relevant to XFS_ERRTAG_BMAP_ALLOC_MINLEN_EXTENT. Patch 9: I think this patch needs to be backported to prevent kmemleak warnings. Patch 10: I would backport this patch since this can prevent kmemleak warnings from showing up (even though the bug was detected after the third patch was applied). But maybe you could wait until I come across these patches when working on backporting commits from v5.11 and newer versions of the kernel. I will share the list of candidate patches with you. Once we agree upon the list of patches, you could then backport them to v5.10-LTS. -- chandan
