Andrew Morton wrote:
> On Thu, 2 Feb 2023 23:01:23 +0000 Matthew Wilcox <willy@xxxxxxxxxxxxx> wrote:
>
> > On Thu, Feb 02, 2023 at 12:33:47PM +0000, Shiyang Ruan wrote:
> > > The copy_mc_to_kernel() will return 0 if it executed successfully.
> > > Then the return value should be set to the length it copied.
> > >
> > > Fixes: d984648e428b ("fsdax,xfs: port unshare to fsdax")
> > > Signed-off-by: Shiyang Ruan <ruansy.fnst@xxxxxxxxxxx>
[..]
>
> Clearer, methinks:
>
> if (copy_mc_to_kernel(daddr, saddr, length) == 0)
> ret = length;
> else
> ret = -EIO;
>
That looks good to me.
