On Mon, Jan 30, 2023 at 09:44:10PM +0530, Ritesh Harjani (IBM) wrote: > TODOs > ====== > 1. I still need to work on macros which we could declare and use for easy > reference to uptodate/dirty bits in iop->state[] bitmap (based on previous > review comments). I'm not sure it was worth posting this series without doing this, tbh. > 5. To address one of the other review comments like what happens with a large > folio. Can we limit the size of bitmaps if the folio is too large e.g. > 2MB. > > [RH] - I can start looking into this area too, if we think these patches > are looking good. My preference would be to work on todos 1-4 as part of this > patch series and take up bitmap optimization as a follow-up work for next > part. Please do let me know your thoughts and suggestions on this. I was hoping to push you towards investigating a better data structure than a bitmap. I know a bitmap solves your immediate problem since there are only 16 4kB blocks in a 64kB page, but in a linear-read scenario, XFS is going to create large folios on POWER machines, all the way up to 16MB IIUC. Whatever your PMD page size is. So you're going to be exposed to this in some scenarios, even if you're not seeing them in your current testing.
