Re: [PATCH v2 1/2] xfs_admin: correctly parse IO_OPTS parameters

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, 2023-01-25 at 16:33 -0800, Catherine Hoang wrote:
> Change exec to eval so that the IO_OPTS parameters are parsed
> correctly
> when the parameters contain quotations.
> 
> Fixes: e7cd89b2da72 ("xfs_admin: get UUID of mounted filesystem")
> Signed-off-by: Catherine Hoang <catherine.hoang@xxxxxxxxxx>
Looks good to me
Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>

> ---
>  db/xfs_admin.sh | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/db/xfs_admin.sh b/db/xfs_admin.sh
> index b73fb3ad..3a7f44ea 100755
> --- a/db/xfs_admin.sh
> +++ b/db/xfs_admin.sh
> @@ -69,7 +69,8 @@ case $# in
>                         fi
>  
>                         if [ -n "$IO_OPTS" ]; then
> -                               exec xfs_io -p xfs_admin $IO_OPTS
> "$mntpt"
> +                               eval xfs_io -p xfs_admin $IO_OPTS
> "$mntpt"
> +                               exit $?
>                         fi
>                 fi
>  





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux