Re: [PATCH] xfsdocs: add epub output

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jan 11, 2023 at 09:15:57AM +0100, Csaba Henk wrote:
> ---
>  .gitignore                               |  1 +
>  admin/Makefile                           | 13 +++++++++++--
>  admin/XFS_Performance_Tuning/Makefile    | 13 +++++++++++--
>  design/Makefile                          | 13 +++++++++++--
>  design/XFS_Filesystem_Structure/Makefile | 13 +++++++++++--
>  5 files changed, 45 insertions(+), 8 deletions(-)

The change looks fine, but why do we need to build documentation in
epub format? Empty commit messages are generally considered a bad
thing - the commit message should explain to us why building epub
format documentation is desired, what problem it solves, what new
dependencies it introduces (e.g. build tools), how we should
determine that the generated documentation is good, etc so that have
some basis from which to evaluate the change from.

Cheers,

Dave.
-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux