On Wed, Nov 30, 2022 at 03:22:28PM +0100, Carlos Maiolino wrote: > > > > +err_loop: > > > > + libxfs_btree_del_cursor(bt_cur, error); > > > > +err_bt_cur: > > > > + libxfs_buf_relse(agbp); > > > > +err_pag: > > > > + libxfs_perag_put(pag); > > > > > > So I see that you fixed one of the labels so that err_pag jumps to > > > releasing the perag pointer, but it's still the case that err_bt_cur > > > frees the AGF buffer, not the btree cursor; and that err_loop actually > > > frees the btree cursor. > > > > Totally true. I focused on your comments regarding err_pag, and forgot to review > > the remaining labels. I'll fix it and send a V3. > > Just to avoid unnecessary new versions :) > Are the fallowing names ok? > > err_cur > err_agf > err_pag Yes, those are fine. The label names reflect whatever gets cleaned up immediately after the label. > Could be err_agbp too, but I'd rather be explicit this buffer belongs to the > agf. Agreed. --D > > > > > Thanks for the review. > > > > -- > Carlos Maiolino
