On Wed, Nov 09, 2022 at 10:16:29AM -0800, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Clean up the ->iomap_begin call sites by passing a pointer to the iter > structure into the iomap_begin functions. This will be needed to clean > up the xfs race condition fixes in the next patch, and will hopefully > reduce register pressure as well. So if we go back to the iomap_iter idea from willy it did something similar, but replaced ->iomap_begin and ->iomap_end with a single iter callback that basically implemented all of iomap_iter(). Depending on your view point this patch gets us closer to that or is pointless churn :) Technicaly the changes look fine to me.