Re: [PATCH 2/2] xfs: check inode core when scrubbing metadata files

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Sun, Oct 02, 2022 at 11:20:26AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> Metadata files (e.g. realtime bitmaps and quota files) do not show up in
> the bulkstat output, which means that scrub-by-handle does not work;
> they can only be checked through a specific scrub type.  Therefore, each
> scrub type calls xchk_metadata_inode_forks to check the metadata for
> whatever's in the file.
> 
> Unfortunately, that function doesn't actually check the inode record
> itself.  Refactor the function a bit to make that happen.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  fs/xfs/scrub/common.c |   40 ++++++++++++++++++++++++++++++++++------
>  1 file changed, 34 insertions(+), 6 deletions(-)

Looks reasonable. Will there be more metadata inode types to scrub
in future?

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux