On Thu, Nov 03, 2022 at 08:36:02 AM -0700, Darrick J. Wong wrote: > On Thu, Nov 03, 2022 at 05:23:55PM +0530, Chandan Babu R wrote: >> Hi Darrick, >> >> This 5.4.y backport series contains fixes from v5.8 release. >> >> This patchset has been tested by executing fstests (via kdevops) using >> the following XFS configurations, >> >> 1. No CRC (with 512 and 4k block size). >> 2. Reflink/Rmapbt (1k and 4k block size). >> 3. Reflink without Rmapbt. >> 4. External log device. >> >> None of the fixes required any other dependent patches to be >> backported. > > Patch 2 is missing quite a bit of commit message context. Something > filtered out the shell screencap: > > "# mkfs.xfs -f /dev/sda" > > Probably because some smart tool thought it was eliding unnecessary > comments or something? Sorry, I had not noticed that. I have sent a V2 of Patch 2 which fixes this problem. Git, by default, uses # as the comment character. I was able to overcome this by adding the following to my ~/.gitconfig, [core] commentChar = $ > > For the other 5 patches, > Acked-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > --D -- chandan
