On Thu, Oct 27, 2022 at 10:14:48AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Now that we have an explicit enum for shared and CoW staging extents, we > can get rid of the old FIND_RCEXT flags. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_refcount.c | 48 +++++++++++++++--------------------------- > 1 file changed, 17 insertions(+), 31 deletions(-) Looks ok. Minor thing below, otherwise Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> > @@ -761,9 +747,9 @@ xfs_refcount_find_right_extents( > > if (tmp.rc_startblock != agbno + aglen) > return 0; > - if ((flags & XFS_FIND_RCEXT_SHARED) && tmp.rc_refcount < 2) > + if (domain == XFS_REFC_DOMAIN_SHARED && tmp.rc_refcount < 2) > return 0; > - if ((flags & XFS_FIND_RCEXT_COW) && tmp.rc_refcount > 1) > + if (domain == XFS_REFC_DOMAIN_COW && tmp.rc_refcount > 1) > return 0; Wouldn't this: if (!xfs_refcount_check_domain(domain, &tmp)) return 0; Do the same thing? -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
