Hi all,
Starting with 6.1-rc1, CONFIG_FORTIFY_SOURCE checks became smart enough
to detect memcpy() callers that copy beyond what seems to be the end of
a struct. Unfortunately, gcc has a bug wherein it cannot reliably
compute the size of a struct containing another struct containing a flex
array at the end. This is the case with the xfs log item format
structures, which means that -rc1 starts complaining all over the place.
Fix these problems by memcpying the struct head and the flex arrays
separately. Although it's tempting to use the FLEX_ARRAY macros, the
structs involved are part of the ondisk log format. Some day we're
going to want to make the ondisk log contents endian-safe, which means
that we will have to stop using memcpy entirely.
While we're at it, fix some deficiencies in the validation of recovered
log intent items -- if the size of the recovery buffer is not even large
enough to cover the flex array record count in the head, we should abort
the recovery of that item immediately.
The last patch of this series changes the EFI/EFD sizeof functions names
and behaviors to be consistent with the similarly named sizeof helpers
for other log intent items.
v2: fix more inadequate log intent done recovery validation and dump
corrupt recovered items
If you're going to start using this mess, you probably ought to just
pull from my git trees, which are linked below.
This is an extraordinary way to destroy everything. Enjoy!
Comments and questions are, as always, welcome.
--D
kernel git tree:
https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=fix-log-recovery-misuse-6.1
---
fs/xfs/libxfs/xfs_log_format.h | 60 +++++++++++++++++++++++---
fs/xfs/xfs_attr_item.c | 65 +++++++++++++---------------
fs/xfs/xfs_bmap_item.c | 54 ++++++++++++-----------
fs/xfs/xfs_extfree_item.c | 94 +++++++++++++++++++---------------------
fs/xfs/xfs_extfree_item.h | 16 +++++++
fs/xfs/xfs_ondisk.h | 23 ++++++++--
fs/xfs/xfs_refcount_item.c | 57 +++++++++++++-----------
fs/xfs/xfs_rmap_item.c | 70 ++++++++++++++++--------------
fs/xfs/xfs_super.c | 12 ++---
9 files changed, 264 insertions(+), 187 deletions(-)
