Re: [PATCH v4 24/27] xfs: Filter XFS_ATTR_PARENT for getfattr

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, 2022-10-25 at 14:34 -0700, Darrick J. Wong wrote:
> On Fri, Oct 21, 2022 at 03:29:33PM -0700,
> allison.henderson@xxxxxxxxxx wrote:
> > From: Allison Henderson <allison.henderson@xxxxxxxxxx>
> > 
> > Parent pointers returned to the get_fattr tool cause errors since
> > the tool cannot parse parent pointers.  Fix this by filtering
> > parent
> > parent pointers from xfs_xattr_put_listent.
> > 
> > Signed-off-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> 
> Looks good,
> Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
Thank you!
Allison
> 
> --D
> 
> > ---
> >  fs/xfs/xfs_xattr.c | 3 +++
> >  1 file changed, 3 insertions(+)
> > 
> > diff --git a/fs/xfs/xfs_xattr.c b/fs/xfs/xfs_xattr.c
> > index d9067c5f6bd6..5b57f6348d63 100644
> > --- a/fs/xfs/xfs_xattr.c
> > +++ b/fs/xfs/xfs_xattr.c
> > @@ -234,6 +234,9 @@ xfs_xattr_put_listent(
> >  
> >         ASSERT(context->count >= 0);
> >  
> > +       if (flags & XFS_ATTR_PARENT)
> > +               return;
> > +
> >         if (flags & XFS_ATTR_ROOT) {
> >  #ifdef CONFIG_XFS_POSIX_ACL
> >                 if (namelen == SGI_ACL_FILE_SIZE &&
> > -- 
> > 2.25.1
> > 





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux