On Mon, Oct 24, 2022 at 02:33:31PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > We've been (ab)using XFS_REFC_COW_START as both an integer quantity and > a bit flag, even though it's *only* a bit flag. Rename the variable to > reflect its nature and update the cast target since we're not supposed > to be comparing it to xfs_agblock_t now. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > fs/xfs/libxfs/xfs_format.h | 2 +- > fs/xfs/libxfs/xfs_refcount.c | 18 +++++++++--------- > fs/xfs/libxfs/xfs_refcount_btree.c | 4 ++-- > 3 files changed, 12 insertions(+), 12 deletions(-) Seems fine, but I think this will change quite a bit if helpers get used for most of these XFS_REFC_COW_START checks... -- Dave Chinner david@xxxxxxxxxxxxx