On Mon, Oct 24, 2022 at 02:32:37PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Before we start fixing all the complaints about memcpy'ing log items > around, let's fix some inadequate validation in the xattr log item > recovery code and get rid of the (now trivial) copy_format function. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> I can't speak to the new checks, but yeah, the decomposition to a direct check and memcpy looks correct. Reviewed-by: Kees Cook <keescook@xxxxxxxxxxxx> -- Kees Cook