On Sun, Oct 02, 2022 at 11:20:09AM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> Teach scrub to flag quota files containing unwritten extents.
>
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
> fs/xfs/scrub/quota.c | 6 ++++--
> 1 file changed, 4 insertions(+), 2 deletions(-)
>
>
> diff --git a/fs/xfs/scrub/quota.c b/fs/xfs/scrub/quota.c
> index d15682e2f2a3..7b21e1012eff 100644
> --- a/fs/xfs/scrub/quota.c
> +++ b/fs/xfs/scrub/quota.c
> @@ -14,6 +14,7 @@
> #include "xfs_inode.h"
> #include "xfs_quota.h"
> #include "xfs_qm.h"
> +#include "xfs_bmap.h"
> #include "scrub/scrub.h"
> #include "scrub/common.h"
>
> @@ -192,11 +193,12 @@ xchk_quota_data_fork(
> for_each_xfs_iext(ifp, &icur, &irec) {
> if (xchk_should_terminate(sc, &error))
> break;
> +
> /*
> - * delalloc extents or blocks mapped above the highest
> + * delalloc/unwritten extents or blocks mapped above the highest
> * quota id shouldn't happen.
> */
> - if (isnullstartblock(irec.br_startblock) ||
> + if (!xfs_bmap_is_written_extent(&irec) ||
> irec.br_startoff > max_dqid_off ||
> irec.br_startoff + irec.br_blockcount - 1 > max_dqid_off) {
> xchk_fblock_set_corrupt(sc, XFS_DATA_FORK,
>
Looks good.
Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
--
Dave Chinner
david@xxxxxxxxxxxxx
