On Thu, Oct 13, 2022 at 10:55:15PM +0800, Zorro Lang wrote:
> On Tue, Oct 11, 2022 at 06:45:27PM -0700, Darrick J. Wong wrote:
> > From: Darrick J. Wong <djwong@xxxxxxxxxx>
> >
> > Not sure why this hasn't been broken all along, but we should be
> > exporting this variable so that it shows up in subshells....
>
> May I ask where's the subshell which uses $POPULATE_METADUMP?
_scratch_xfs_fuzz_metadata does this:
echo "${fields}" | while read field; do
echo "${verbs}" | while read fuzzverb; do
__scratch_xfs_fuzz_mdrestore
_xfs_mdrestore "${POPULATE_METADUMP}"
The (nested) echo piped to while starts subshells.
> >
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > ---
> > common/populate | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> >
> > diff --git a/common/populate b/common/populate
> > index cfdaf766f0..b501c2fe45 100644
> > --- a/common/populate
> > +++ b/common/populate
> > @@ -868,9 +868,9 @@ _scratch_populate_cached() {
> > local meta_tag="$(echo "${meta_descr}" | md5sum - | cut -d ' ' -f 1)"
> > local metadump_stem="${TEST_DIR}/__populate.${FSTYP}.${meta_tag}"
> >
> > - # These variables are shared outside this function
> > - POPULATE_METADUMP="${metadump_stem}.metadump"
> > - POPULATE_METADUMP_DESCR="${metadump_stem}.txt"
> > + # This variable is shared outside this function
> > + export POPULATE_METADUMP="${metadump_stem}.metadump"
> > + local POPULATE_METADUMP_DESCR="${metadump_stem}.txt"
>
> If the POPULATE_METADUMP_DESCR is not shared outside anymore, how about change
> it to lower-case?
Ok.
--D
> >
> > # Don't keep metadata images cached for more 48 hours...
> > rm -rf "$(find "${POPULATE_METADUMP}" -mtime +2 2>/dev/null)"
> >
>
