Hi all, This series addresses some deficiencies in btree key comparisons that I noticed while testing online scrub. The first fixes a bug in the rmap key comparison that prevents the rmap scrubber from detecting rmap records for file space allocations with mismatched attr/bmbt flags. The second patch fixes the scrub btree block checker to ensure that the keys in the parent block accurately represent the block. If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below. This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=btree-key-enhancements xfsprogs git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=btree-key-enhancements --- fs/xfs/libxfs/xfs_rmap_btree.c | 25 ++++++++++++++------ fs/xfs/scrub/btree.c | 49 +++++++++++++++++++++++++++++++++++++++- 2 files changed, 65 insertions(+), 9 deletions(-)