Hi all, While reading through the online fsck code, I noticed that the setup code for AG metadata scrubs will attach the AGI, the AGF, and the AGFL buffers to the transaction. It isn't necessary to hold the AGFL buffer, since any code that wants to do anything with the AGFL will need to hold the AGF to know which parts of the AGFL are active. Therefore, we only need to hold the AGFL when scrubbing the AGFL itself. The second bug fixed by this patchset is one that I observed while testing online repair. When a buffer is held across a transaction roll, its buffer log item will be detached if the bli was clean before the roll. If we are holding the AG headers to maintain a lock on an AG, we then need to set the buffer type on the new bli to avoid confusing the logging code later. There's also a bug fix for uninitialized memory in the directory scanner that didn't fit anywhere else. Ths patchset finishes off by teaching the AGFL repair function to look for and discard crosslinked blocks instead of putting them back on the AGFL. Is this a bug fix? Or merely an enhancement? If you're going to start using this mess, you probably ought to just pull from my git trees, which are linked below. This is an extraordinary way to destroy everything. Enjoy! Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=scrub-fix-ag-header-handling --- fs/xfs/scrub/agheader.c | 47 +++++++++++++++--------- fs/xfs/scrub/agheader_repair.c | 79 +++++++++++++++++++++++++++++++++------- fs/xfs/scrub/common.c | 8 ---- fs/xfs/scrub/dir.c | 10 +++-- fs/xfs/scrub/repair.c | 29 +++++++++++---- fs/xfs/scrub/scrub.h | 1 - 6 files changed, 122 insertions(+), 52 deletions(-)
