On Fri, 2022-09-23 at 14:22 -0700, Darrick J. Wong wrote: > On Wed, Sep 21, 2022 at 10:44:51PM -0700, > allison.henderson@xxxxxxxxxx wrote: > > From: Allison Henderson <allison.henderson@xxxxxxxxxx> > > > > Indent variables and parameters in xfs_rename in preparation for > > parent pointer modifications. White space only, no functional > > changes. This will make reviewing new code easier on reviewers. > > > > Signed-off-by: Allison Henderson <allison.henderson@xxxxxxxxxx> > > Easy enough :) > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> Thank you! Allison > > --D > > > --- > > fs/xfs/xfs_inode.c | 39 ++++++++++++++++++++------------------- > > 1 file changed, 20 insertions(+), 19 deletions(-) > > > > diff --git a/fs/xfs/xfs_inode.c b/fs/xfs/xfs_inode.c > > index 51724af22bf9..4a8399d35b17 100644 > > --- a/fs/xfs/xfs_inode.c > > +++ b/fs/xfs/xfs_inode.c > > @@ -2891,26 +2891,27 @@ xfs_rename_alloc_whiteout( > > */ > > int > > xfs_rename( > > - struct user_namespace *mnt_userns, > > - struct xfs_inode *src_dp, > > - struct xfs_name *src_name, > > - struct xfs_inode *src_ip, > > - struct xfs_inode *target_dp, > > - struct xfs_name *target_name, > > - struct xfs_inode *target_ip, > > - unsigned int flags) > > + struct user_namespace *mnt_userns, > > + struct xfs_inode *src_dp, > > + struct xfs_name *src_name, > > + struct xfs_inode *src_ip, > > + struct xfs_inode *target_dp, > > + struct xfs_name *target_name, > > + struct xfs_inode *target_ip, > > + unsigned int flags) > > { > > - struct xfs_mount *mp = src_dp->i_mount; > > - struct xfs_trans *tp; > > - struct xfs_inode *wip = NULL; /* whiteout > > inode */ > > - struct xfs_inode *inodes[__XFS_SORT_INODES]; > > - int i; > > - int num_inodes = __XFS_SORT_INODES; > > - bool new_parent = (src_dp != target_dp); > > - bool src_is_directory = > > S_ISDIR(VFS_I(src_ip)->i_mode); > > - int spaceres; > > - bool retried = false; > > - int error, nospace_error = 0; > > + struct xfs_mount *mp = src_dp->i_mount; > > + struct xfs_trans *tp; > > + struct xfs_inode *wip = NULL; /* whiteout > > inode */ > > + struct xfs_inode *inodes[__XFS_SORT_INODES]; > > + int i; > > + int num_inodes = > > __XFS_SORT_INODES; > > + bool new_parent = (src_dp != > > target_dp); > > + bool src_is_directory = > > + S_ISDIR(VFS_I(src_i > > p)->i_mode); > > + int spaceres; > > + bool retried = false; > > + int error, nospace_error = 0; > > > > trace_xfs_rename(src_dp, target_dp, src_name, target_name); > > > > -- > > 2.25.1 > >