Re: [PATCH 5.4 CANDIDATE 0/2] xfs stable candidate patches for 5.4.y

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 23, 2022 at 12:51:47PM +0530, Chandan Babu R wrote:
> Hi Darrick,
> 
> Two of the commits backported from v5.5
> (https://lore.kernel.org/linux-xfs/YywzGEFApUMalXNn@xxxxxxxxx/T/#t)
> introduced regressions of their own. Hence this patchset includes two
> backported commits to fix those regressions.
> 
> The first patch i.e. "xfs: fix an ABBA deadlock in xfs_rename" fixes a
> regression that was introduced by "xfs: Fix deadlock between AGI and
> AGF when target_ip exists in xfs_rename()".
> 
> The second patch i.e. "xfs: fix use-after-free when aborting corrupt
> attr inactivation" fixes a regression that was introduced by "xfs: fix
> use-after-free when aborting corrupt attr inactivation".

Looks good to me, thanks for fishing out these two extra fixes.
Acked-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D

>    
> This patchset has been tested by executing fstests (via kdevops) using
> the following XFS configurations,
> 1. No CRC (with 512 and 4k block size).
> 2. Reflink/Rmapbt (1k and 4k block size).
> 3. Reflink without Rmapbt.
> 4. External log device.
> 
> Darrick J. Wong (2):
>   xfs: fix an ABBA deadlock in xfs_rename
>   xfs: fix use-after-free when aborting corrupt attr inactivation
> 
>  fs/xfs/libxfs/xfs_dir2.h    |  2 --
>  fs/xfs/libxfs/xfs_dir2_sf.c |  2 +-
>  fs/xfs/xfs_attr_inactive.c  |  2 +-
>  fs/xfs/xfs_inode.c          | 42 ++++++++++++++++++++++---------------
>  4 files changed, 27 insertions(+), 21 deletions(-)
> 
> -- 
> 2.35.1
> 



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux