Re: [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Subject: Re: [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock
From: Christoph Hellwig <hch@xxxxxxxxxxxxx>
Date: Thu, 11 Aug 2022 05:47:26 -0700
Cc: sandeen@xxxxxxxxxxx, linux-xfs@xxxxxxxxxxxxxxx
In-reply-to: <166007921743.3294543.7334567013352169774.stgit@magnolia>
References: <166007920625.3294543.10714247329798384513.stgit@magnolia> <166007921743.3294543.7334567013352169774.stgit@magnolia>

Maybe we just simply need to set NEEDSREPAIR for any run that does
not specify the no-modify flag and avoid this magic lazy behavior?

That being said the code looks sane if we can't fix this better by
just working differently.

Follow-Ups:
- Re: [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock
  - From: Darrick J. Wong

References:
- [PATCHSET v2 0/2] xfsprogs: random fixes for 5.19
  - From: Darrick J. Wong
- [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock
  - From: Darrick J. Wong

Prev by Date: Re: [PATCH 1/2] xfs_repair: fix printf format specifiers on 32-bit platforms
Next by Date: Re: [PATCH 1/2] Remove trailing white spaces from xfsdump.html
Previous by thread: [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock
Next by thread: Re: [PATCH 2/2] xfs_repair: retain superblock buffer to avoid write hook deadlock
Index(es):
- Date
- Thread

[Index of Archives] [XFS Filesystem Development (older mail)] [Linux Filesystem Development] [Linux Audio Users] [Yosemite Trails] [Linux Kernel] [Linux RAID] [Linux SCSI]

Powered by Linux