On Wed, Aug 10, 2022 at 11:32:06PM +0200, Andreas Grünbacher wrote: > Am Mi., 10. Aug. 2022 um 22:57 Uhr schrieb Matthew Wilcox <willy@xxxxxxxxxxxxx>: > > On Mon, Aug 01, 2022 at 11:31:50AM -0400, Johannes Weiner wrote: > > > XFS hasn't had a ->writepage call for a while. After LSF I internally > > > tested dropping btrfs' callback, and the results looked good: no OOM > > > kills with dirty/writeback pages remaining, performance parity. Then I > > > went on vacation and Christoph beat me to the patch :) > > > > To avoid duplicating work with you or Christoph ... it seems like the > > plan is to kill ->writepage entirely soon, so there's no point in me > > doing a sweep of all the filesystems to convert ->writepage to > > ->write_folio, correct? > > > > I assume the plan for filesystems which have a writepage but don't have > > a ->writepages (9p, adfs, affs, bfs, ecryptfs, gfs2, hostfs, jfs, minix, > > nilfs2, ntfs, ocfs2, reiserfs, sysv, ubifs, udf, ufs, vboxsf) is to give > > them a writepages, modelled on iomap_writepages(). Seems that adding > > a block_writepages() might be a useful thing for me to do? > > Hmm, gfs2 does have gfs2_writepages() and gfs2_jdata_writepages() > functions, so it should probably be fine. Ah, it's gfs2_aspace_writepage which doesn't have a writepages counterpart. I haven't looked at it to understand why it's needed. (gfs2_meta_aops and gfs2_rgrp_aops)
