On Tue, Aug 02, 2022 at 09:21:26PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > This program exercises metadump and mdrestore being run against the > scratch device. Therefore, the test must pass external log / rt device > arguments to xfs_repair -n to check the "restored" filesystem. Fix the > incorrect usage, and report repair failures, since this test has been > silently failing for a while now. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > tests/xfs/432 | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > > diff --git a/tests/xfs/432 b/tests/xfs/432 > index 86012f0b..e1e610d0 100755 > --- a/tests/xfs/432 > +++ b/tests/xfs/432 > @@ -89,7 +89,8 @@ _scratch_xfs_metadump $metadump_file -w > xfs_mdrestore $metadump_file $metadump_img > > echo "Check restored metadump image" > -$XFS_REPAIR_PROG -n $metadump_img >> $seqres.full 2>&1 > +SCRATCH_DEV=$metadump_img _scratch_xfs_repair -n &>> $seqres.full || \ > + echo "xfs_repair on restored fs returned $?" It's good to me, Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx> If anyone has more review points, please feel free to tell us :) > > # success, all done > status=0 >
