From: Darrick J. Wong <djwong@xxxxxxxxxx> There's a slight mistake in _reset_xfs_sysfs_error_handling: it sets retry_timeout_seconds to 0, which is not the current default (-1) in upstream Linux. Fix this. Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> --- common/xfs | 2 +- tests/xfs/006.out | 6 +++--- tests/xfs/264.out | 12 ++++++------ 3 files changed, 10 insertions(+), 10 deletions(-) diff --git a/common/xfs b/common/xfs index 9f84dffb..ba72027c 100644 --- a/common/xfs +++ b/common/xfs @@ -781,7 +781,7 @@ _reset_xfs_sysfs_error_handling() _get_fs_sysfs_attr $dev error/metadata/${e}/max_retries _set_fs_sysfs_attr $dev \ - error/metadata/${e}/retry_timeout_seconds 0 + error/metadata/${e}/retry_timeout_seconds -1 echo -n "error/metadata/${e}/retry_timeout_seconds=" _get_fs_sysfs_attr $dev \ error/metadata/${e}/retry_timeout_seconds diff --git a/tests/xfs/006.out b/tests/xfs/006.out index 3260b3a2..433b0bc3 100644 --- a/tests/xfs/006.out +++ b/tests/xfs/006.out @@ -1,8 +1,8 @@ QA output created by 006 error/fail_at_unmount=1 error/metadata/default/max_retries=-1 -error/metadata/default/retry_timeout_seconds=0 +error/metadata/default/retry_timeout_seconds=-1 error/metadata/EIO/max_retries=-1 -error/metadata/EIO/retry_timeout_seconds=0 +error/metadata/EIO/retry_timeout_seconds=-1 error/metadata/ENOSPC/max_retries=-1 -error/metadata/ENOSPC/retry_timeout_seconds=0 +error/metadata/ENOSPC/retry_timeout_seconds=-1 diff --git a/tests/xfs/264.out b/tests/xfs/264.out index 502e72d3..e45ac5a5 100644 --- a/tests/xfs/264.out +++ b/tests/xfs/264.out @@ -2,20 +2,20 @@ QA output created by 264 === Test EIO/max_retries === error/fail_at_unmount=1 error/metadata/default/max_retries=-1 -error/metadata/default/retry_timeout_seconds=0 +error/metadata/default/retry_timeout_seconds=-1 error/metadata/EIO/max_retries=-1 -error/metadata/EIO/retry_timeout_seconds=0 +error/metadata/EIO/retry_timeout_seconds=-1 error/metadata/ENOSPC/max_retries=-1 -error/metadata/ENOSPC/retry_timeout_seconds=0 +error/metadata/ENOSPC/retry_timeout_seconds=-1 error/fail_at_unmount=0 error/metadata/EIO/max_retries=1 === Test EIO/retry_timeout_seconds === error/fail_at_unmount=1 error/metadata/default/max_retries=-1 -error/metadata/default/retry_timeout_seconds=0 +error/metadata/default/retry_timeout_seconds=-1 error/metadata/EIO/max_retries=-1 -error/metadata/EIO/retry_timeout_seconds=0 +error/metadata/EIO/retry_timeout_seconds=-1 error/metadata/ENOSPC/max_retries=-1 -error/metadata/ENOSPC/retry_timeout_seconds=0 +error/metadata/ENOSPC/retry_timeout_seconds=-1 error/fail_at_unmount=0 error/metadata/EIO/retry_timeout_seconds=1