Hi all, This is the latest rebase of parent pointer attributes for xfs. The goal of this patch set is to add a parent pointer attribute to each inode. The attribute name containing the parent inode, generation, and directory offset, while the attribute value contains the file name. This feature will enable future optimizations for online scrub, or any other feature that could make use of quickly deriving an inodes path from the mount point. This set can be viewed on github here https://github.com/allisonhenderson/xfs/tree/xfs_new_pptrsv2 And the corresponding xfsprogs code is here https://github.com/allisonhenderson/xfsprogs/tree/xfsprogs_new_pptrsv2 This set has been tested with the below parent pointers tests https://www.spinics.net/lists/fstests/msg19963.html Updates since v2: xfs: Fix multi-transaction larp replay Resend xfs: Increase XFS_DEFER_OPS_NR_INODES to 5 Increased XFS_DEFER_OPS_NR_INODES from 4 to 5 Moved to beginning of the set Added code in xfs_defer_ops_continue to sort the inodes Added commentary about which inodes are locked xfs: Hold inode locks in xfs_trans_alloc_dir New patch xfs: add parent pointer support to attribute code Typo fix xfs: extend transaction reservations for parent attribute Made xfs_calc_parent_ptr_reservations static Whitespace fixes xfs: parent pointer attribute creation Fixed SPDX License Headers Updated xfs_sb_version_hasparent to xfs_has_parent Type def conversions Whitespace Added helper functions: xfs_parent_init, xfs_parent_defer_add, xfs_parent_cancel Investigated mount option that overrides larp option: The larp global itself isnt used with in the delayed ops machinery due to race conditions with the syscall being toggled. Pptrs dont toggle so we can just set XFS_DA_OP_LOGGED to log the pptr with out requireing all attrs be logged xfs: add parent attributes to link Rebase to use new helpers: xfs_parent_init, xfs_parent_defer_add, xfs_parent_cancel, xfs_has_parent xfs: add parent attributes to unlink rebase to use new helpers added helper function xfs_parent_defer_remove xfs: Add parent pointers to rename added extra parent remove for target_ip unlinks rebase to use new helpers xfs: Add the parent pointer support to the superblock version 5. changed XFS_SB_FEAT_RO_COMPAT_PARENT to XFS_SB_FEAT_INCOMPAT_PARENT xfs: Increase XFS_DEFER_OPS_NR_INODES to 5 Added comentarty explaining which inodes are locked Updated commit comment updated xfs_defer_ops_continue to relock inodes in the same order they are locked xfs: Add parent pointer ioctl Added pi_parents[] to struct xfs_parent_ptr Changed pptr helper defines into inline functions White space/indentation Reordered flag check in xfs_ioc_get_parent_pointer to be before the alloc Added gen number check in xfs_ioc_get_parent_pointer Init args in loop body of xfs_attr_get_parent_pointer Questions comments and feedback appreciated! Thanks all! Allison Allison Henderson (18): xfs: Fix multi-transaction larp replay xfs: Increase XFS_DEFER_OPS_NR_INODES to 5 xfs: Hold inode locks in xfs_ialloc xfs: Hold inode locks in xfs_trans_alloc_dir xfs: get directory offset when adding directory name xfs: get directory offset when removing directory name xfs: get directory offset when replacing a directory name xfs: add parent pointer support to attribute code xfs: define parent pointer xattr format xfs: Add xfs_verify_pptr xfs: extend transaction reservations for parent attributes xfs: parent pointer attribute creation xfs: add parent attributes to link xfs: remove parent pointers in unlink xfs: Add parent pointers to rename xfs: Add the parent pointer support to the superblock version 5. xfs: Add helper function xfs_attr_list_context_init xfs: Add parent pointer ioctl fs/xfs/Makefile | 2 + fs/xfs/libxfs/xfs_attr.c | 53 ++++++- fs/xfs/libxfs/xfs_attr.h | 8 +- fs/xfs/libxfs/xfs_da_btree.h | 1 + fs/xfs/libxfs/xfs_da_format.h | 30 +++- fs/xfs/libxfs/xfs_defer.c | 28 +++- fs/xfs/libxfs/xfs_defer.h | 8 +- fs/xfs/libxfs/xfs_dir2.c | 21 ++- fs/xfs/libxfs/xfs_dir2.h | 7 +- fs/xfs/libxfs/xfs_dir2_block.c | 9 +- fs/xfs/libxfs/xfs_dir2_leaf.c | 8 +- fs/xfs/libxfs/xfs_dir2_node.c | 8 +- fs/xfs/libxfs/xfs_dir2_sf.c | 6 + fs/xfs/libxfs/xfs_format.h | 4 +- fs/xfs/libxfs/xfs_fs.h | 58 +++++++ fs/xfs/libxfs/xfs_log_format.h | 1 + fs/xfs/libxfs/xfs_parent.c | 159 +++++++++++++++++++ fs/xfs/libxfs/xfs_parent.h | 39 +++++ fs/xfs/libxfs/xfs_sb.c | 4 + fs/xfs/libxfs/xfs_trans_resv.c | 105 ++++++++++--- fs/xfs/scrub/attr.c | 2 +- fs/xfs/xfs_attr_item.c | 41 ++--- fs/xfs/xfs_attr_list.c | 17 ++- fs/xfs/xfs_file.c | 1 + fs/xfs/xfs_inode.c | 271 +++++++++++++++++++++++++-------- fs/xfs/xfs_inode.h | 1 + fs/xfs/xfs_ioctl.c | 149 +++++++++++++++--- fs/xfs/xfs_ioctl.h | 2 + fs/xfs/xfs_ondisk.h | 4 + fs/xfs/xfs_parent_utils.c | 134 ++++++++++++++++ fs/xfs/xfs_parent_utils.h | 22 +++ fs/xfs/xfs_qm.c | 4 +- fs/xfs/xfs_super.c | 4 + fs/xfs/xfs_symlink.c | 6 +- fs/xfs/xfs_trans.c | 6 +- fs/xfs/xfs_xattr.c | 2 +- fs/xfs/xfs_xattr.h | 1 + 37 files changed, 1056 insertions(+), 170 deletions(-) create mode 100644 fs/xfs/libxfs/xfs_parent.c create mode 100644 fs/xfs/libxfs/xfs_parent.h create mode 100644 fs/xfs/xfs_parent_utils.c create mode 100644 fs/xfs/xfs_parent_utils.h -- 2.25.1
