On Fri, Jul 08, 2022 at 11:55:58AM +1000, Dave Chinner wrote: > +void > xlog_grant_sub_space( > struct xlog *log, > struct xlog_grant_head *head, > int bytes) > { > + atomic64_sub(bytes, &head->grant); > } > > static void > @@ -165,93 +144,34 @@ xlog_grant_add_space( > struct xlog_grant_head *head, > int bytes) > { > + atomic64_add(bytes, &head->grant); > } These probably make more senses as inlines and can you can drop their log agument as well. Or maybe just drop these helpers entirely?