On Wed, Jun 29, 2022 at 03:06:31PM -0700, Darrick J. Wong wrote:
> On Wed, Jun 29, 2022 at 12:40:08AM -0700, Christoph Hellwig wrote:
> > >
> > > -static inline struct xfs_buf *
> > > -xfs_buf_find_fast(
> > > - struct xfs_perag *pag,
> > > - struct xfs_buf_map *map)
> > > -{
> > > - struct xfs_buf *bp;
> > > -
> > > - bp = rhashtable_lookup(&pag->pag_buf_hash, map, xfs_buf_hash_params);
> > > - if (!bp)
> > > - return NULL;
> > > - atomic_inc(&bp->b_hold);
> > > - return bp;
> > > -}
> >
> > > -static int
> > > -xfs_buf_find_insert(
> > > - struct xfs_buftarg *btp,
> > > - struct xfs_perag *pag,
> >
> > Adding the function just in the last patch and moving them around
> > here and slighty changing seems a little counter productive.
> > I think just merging the two might actually end up with a result
> > that is easier to review.
>
> I read the second patch and it makes sense, but I'm also curious if
> hch's suggestion here would make this change easier to read?
I moved the initial placement of these functions around and it took
a big chunk out of the diff in this patch. That should make it
easier to read without combining the two patches together...
Cheers,
Dave.
--
Dave Chinner
david@xxxxxxxxxxxxx
