On Thu, Jun 30, 2022 at 07:44:58AM +1000, Dave Chinner wrote: > On Wed, Jun 29, 2022 at 02:21:30PM -0700, Darrick J. Wong wrote: > > On Mon, Jun 27, 2022 at 10:43:36AM +1000, Dave Chinner wrote: > > > diff --git a/fs/xfs/xfs_iunlink_item.c b/fs/xfs/xfs_iunlink_item.c > > > new file mode 100644 > > > index 000000000000..fe38fc61f79e > > > --- /dev/null > > > +++ b/fs/xfs/xfs_iunlink_item.c > > > @@ -0,0 +1,180 @@ > > > +// SPDX-License-Identifier: GPL-2.0 > > > +/* > > > + * Copyright (c) 2020, Red Hat, Inc. > > > > 2022? > > 2020 is correct - that's when I originally wrote this and first published it. > > > > + * All Rights Reserved. > > > + */ > > > +#include "xfs.h" > > > +#include "xfs_fs.h" > > > +#include "xfs_shared.h" > > > +#include "xfs_format.h" > > > +#include "xfs_log_format.h" > > > +#include "xfs_trans_resv.h" > > > +#include "xfs_mount.h" > > > +#include "xfs_inode.h" > > > +#include "xfs_trans.h" > > > +#include "xfs_trans_priv.h" > > > +#include "xfs_ag.h" > > > +#include "xfs_iunlink_item.h" > > > +#include "xfs_trace.h" > > > +#include "xfs_error.h" > > > + > > > +struct kmem_cache *xfs_iunlink_cache; > > > + > > > +static inline struct xfs_iunlink_item *IUL_ITEM(struct xfs_log_item *lip) > > > +{ > > > + return container_of(lip, struct xfs_iunlink_item, item); > > > +} > > > + > > > +static void > > > +xfs_iunlink_item_release( > > > + struct xfs_log_item *lip) > > > +{ > > > + struct xfs_iunlink_item *iup = IUL_ITEM(lip); > > > + > > > + xfs_perag_put(iup->pag); > > > + kmem_cache_free(xfs_iunlink_cache, IUL_ITEM(lip)); > > > +} > > > + > > > + > > > +static uint64_t > > > +xfs_iunlink_item_sort( > > > + struct xfs_log_item *lip) > > > +{ > > > + return IUL_ITEM(lip)->ip->i_ino; > > > +} > > > > Since you mentioned in-memory log items for dquots -- how should > > iunlinks and dquot log items be sorted? > > ip->i_ino is the physical location of the inode - I'd use the > physical location of the dquot buffer if that was being logged. > > > (On the off chance the dquot comment was made off the cuff and you don't > > have a patchset ready to go in your dev tree -- I probably wouldn't have > > said anything if this looked like the usual comparator function.) > > No, there's nothing coming down the line for dquots right now. Ok. > > > +/* > > > + * On precommit, we grab the inode cluster buffer for the inode number we were > > > + * passed, then update the next unlinked field for that inode in the buffer and > > > + * log the buffer. This ensures that the inode cluster buffer was logged in the > > > + * correct order w.r.t. other inode cluster buffers. We can then remove the > > > + * iunlink item from the transaction and release it as it is has now served it's > > > + * purpose. > > > + */ > > > +static int > > > +xfs_iunlink_item_precommit( > > > + struct xfs_trans *tp, > > > + struct xfs_log_item *lip) > > > +{ > > > + struct xfs_iunlink_item *iup = IUL_ITEM(lip); > > > + int error; > > > + > > > + error = xfs_iunlink_log_dinode(tp, iup); > > > > Hmm, so does this imply that log items can create new log items now? > > Yup, now it's been sorted, we can lock the buffer, modify the > unlinked list and log the buffer, adding the new buffer log item to > the transaction. > > That's the whole point of the in-memory log item - it records the > change to be made, then delays the physical change until it is safe > to lock the object we need to change. Wheeee :) > This minimises the length of time we have to hold the object locked > during a transaction by dissociating the in-memory change from the > on-disk format changes. I plan to use this technique a lot more in > future... Cool. All I can think of is matrixpeople transmogrifying into Agent Smiths :P Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > > Cheers, > > Dave. > -- > Dave Chinner > david@xxxxxxxxxxxxx