On Thu, Jun 23, 2022 at 01:40:06PM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > The end of this function could use some cleanup -- the EAGAIN > conditionals make it harder to figure out what's going on with the > disposal of xattri_leaf_bp, and the dual error/ret variables aren't > needed. Turn the EAGAIN case into a separate block documenting all the > subtleties of recovering in the middle of an xattr update chain, which > makes the rest of the prologue much simpler. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> Decent cleanup. :) Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx