On Tue, Jun 21, 2022 at 03:02:24PM +0800, Shida Zhang wrote: > Checks are missing when delta equals 0 in __xfs_ag_resv_free() and > __xfs_ag_resv_init(). This describes what the patch does, not the problem being solved is. i.e. This doesn't tell the reader why the delta can be zero in these places, nor does it tell them what the impact of it being zero is. We can't use this information to identify a system that is having problems due to this issue because they havent' been described. Hence when I ask for more detail about how something occurs, what I'm asking for is a description of the how the problem was found, what the impact of the problem has on systems, how the problem is reproduced, etc. Something led you to finding this problem - tell us the story so we also know what you know and so can understand why the change needs to be made. A good commit description tells the reader everything you know about the problem that needs to be fixed, the code change itself will then describe how the problem was fixed... Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
