On Fri, Jun 17, 2022 at 10:30:33AM +0800, xiakaixu1987@xxxxxxxxx wrote: > From: Kaixu Xia <kaixuxia@xxxxxxxxxxx> > > There are similar lock flags assert in xfs_ilock(), xfs_ilock_nowait(), > xfs_iunlock(), thus we can factor it out into a helper that is clear. > > Signed-off-by: Kaixu Xia <kaixuxia@xxxxxxxxxxx> > --- > fs/xfs/xfs_inode.c | 60 ++++++++++++++++++---------------------------- > 1 file changed, 23 insertions(+), 37 deletions(-) looks fine. Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx