On Sat, Jun 11, 2022 at 11:26:12AM +1000, Dave Chinner wrote: > @@ -833,7 +835,7 @@ xfs_ag_shrink_space( > xfs_trans_bhold(*tpp, agfbp); > err2 = xfs_trans_roll(tpp); > if (err2) > - return err2; > + return error; > xfs_trans_bjoin(*tpp, agfbp); > goto resv_init_out; > } This change looks unrelated and is undocumented. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
