On Tue, 2022-06-07 at 14:03 -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
>
> The variable @args is fed to a tracepoint, and that's the only place
> it's used. This is fine for the kernel, but for userspace,
> tracepoints
> are #define'd out of existence, which results in this warning on gcc
> 11.2:
>
> xfs_attr.c: In function ‘xfs_attr_node_try_addname’:
> xfs_attr.c:1440:42: warning: unused variable ‘args’ [-Wunused-
> variable]
> 1440 | struct xfs_da_args *args = attr-
> >xattri_da_args;
> | ^~~~
>
> Clean this up.
>
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>
Reviewed-by: Allison Henderson <allison.henderson@xxxxxxxxxx>
> ---
> fs/xfs/libxfs/xfs_attr.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
>
> diff --git a/fs/xfs/libxfs/xfs_attr.c b/fs/xfs/libxfs/xfs_attr.c
> index 0847b4e16237..1824f61621a2 100644
> --- a/fs/xfs/libxfs/xfs_attr.c
> +++ b/fs/xfs/libxfs/xfs_attr.c
> @@ -1441,12 +1441,11 @@ static int
> xfs_attr_node_try_addname(
> struct xfs_attr_intent *attr)
> {
> - struct xfs_da_args *args = attr->xattri_da_args;
> struct xfs_da_state *state = attr-
> >xattri_da_state;
> struct xfs_da_state_blk *blk;
> int error;
>
> - trace_xfs_attr_node_addname(args);
> + trace_xfs_attr_node_addname(state->args);
>
> blk = &state->path.blk[state->path.active-1];
> ASSERT(blk->magic == XFS_ATTR_LEAF_MAGIC);
>
