On Thu, Jun 02, 2022 at 08:59:01PM +0100, Matthew Wilcox wrote: > On Thu, Jun 02, 2022 at 07:41:55PM +0000, Chris Mason wrote: > > > > > On Jun 2, 2022, at 11:32 AM, Johannes Weiner <hannes@xxxxxxxxxxx> wrote: > > > > > > On Thu, Jun 02, 2022 at 04:52:52PM +1000, Dave Chinner wrote: > > >> > > >> Further, I don't think we need to invalidate the folio, either. If > > >> it's beyond EOF, then it is because a truncate is in progress that > > >> means it is somebody else's problem to clean up. Hence we should > > >> leave it to the truncate to deal with, just like the pre-2013 code > > >> did.... > > > > > > Perfect, that works. > > > > Ok, I’ll run it through xfstests and resend a v2. Will this cover all of the subpage blocksize concerns? > > I run with: > export MKFS_OPTIONS="-m reflink=1,rmapbt=1 -i sparse=1 -b size=1024" > > Dave may have other options he'd like to see. No, that above is what I'd suggest. Cheers, Dave. -- Dave Chinner david@xxxxxxxxxxxxx
