Re: [PATCH 2/5] xfs: implement per-mount warnings for scrub and shrink usage

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, May 23, 2022 at 10:36:31PM -0700, Darrick J. Wong wrote:
> From: Darrick J. Wong <djwong@xxxxxxxxxx>
> 
> Currently, we don't have a consistent story around logging when an
> EXPERIMENTAL feature gets turned on at runtime -- online fsck and shrink
> log a message once per day across all mounts, and the recently merged
> LARP mode only ever does it once per insmod cycle or reboot.
> 
> Because EXPERIMENTAL tags are supposed to go away eventually, convert
> the existing daily warnings into state flags that travel with the mount,
> and warn once per mount.  Making this an opstate flag means that we'll
> be able to capture the experimental usage in the ftrace output too.
> 
> Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> ---
>  fs/xfs/scrub/scrub.c |   17 ++---------------
>  fs/xfs/xfs_fsops.c   |    7 +------
>  fs/xfs/xfs_message.h |    6 ++++++
>  fs/xfs/xfs_mount.h   |   15 ++++++++++++++-
>  4 files changed, 23 insertions(+), 22 deletions(-)

nice - I like the xfs_warn_mount() wrapper.

Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx>

-- 
Dave Chinner
david@xxxxxxxxxxxxx



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux