https://bugzilla.kernel.org/show_bug.cgi?id=216007 --- Comment #8 from Peter Pavlisko (bugzkernelorg8392@xxxxxxxxx) --- (In reply to Peter Pavlisko from comment #7) > Furthermore, I was able to do a git bisect on this repository: > > git://git.kernel.org/pub/scm/linux/kernel/git/stable/linux.git > > The offending commit is this one: > > 9ba0889e2272294bfbb5589b1b180ad2e782b2a4 is the first bad commit > commit 9ba0889e2272294bfbb5589b1b180ad2e782b2a4 > Author: Dave Chinner <david@xxxxxxxxxxxxx> > Date: Tue Jun 8 09:19:22 2021 -0700 > > xfs: drop the AGI being passed to xfs_check_agi_freecount > > From: Dave Chinner <dchinner@xxxxxxxxxx> > > Stephen Rothwell reported this compiler warning from linux-next: > > fs/xfs/libxfs/xfs_ialloc.c: In function 'xfs_difree_finobt': > fs/xfs/libxfs/xfs_ialloc.c:2032:20: warning: unused variable 'agi' > [-Wunused-variable] > 2032 | struct xfs_agi *agi = agbp->b_addr; > > Which is fallout from agno -> perag conversions that were done in > this function. xfs_check_agi_freecount() is the only user of "agi" > in xfs_difree_finobt() now, and it only uses the agi to get the > current free inode count. We hold that in the perag structure, so > there's not need to directly reference the raw AGI to get this > information. > > The btree cursor being passed to xfs_check_agi_freecount() has a > reference to the perag being operated on, so use that directly in > xfs_check_agi_freecount() rather than passing an AGI. > > Fixes: 7b13c5155182 ("xfs: use perag for ialloc btree cursors") > Reported-by: Stephen Rothwell <sfr@xxxxxxxxxxxxxxxx> > Signed-off-by: Dave Chinner <dchinner@xxxxxxxxxx> > Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx> > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > fs/xfs/libxfs/xfs_ialloc.c | 28 +++++++++++++--------------- > 1 file changed, 13 insertions(+), 15 deletions(-) I'm sorry, I made a mistake somewhere while bisecting... This is not the commit. Disregard the quoted message, please. I will try bisecting again. -- You may reply to this email to add a comment. You are receiving this mail because: You are watching the assignee of the bug.
