On Fri, May 20, 2022 at 11:36:34AM -0700, Stefan Roesch wrote: > - iop = kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)), > - GFP_NOFS | __GFP_NOFAIL); > + iop = kzalloc(struct_size(iop, uptodate, BITS_TO_LONGS(nr_blocks)), gfp); Please avoid the overly long line. Looking at this I also thnk my second suggestion of just passing the flags to iomap_page_create and let iomap_page_create itself pick the gfp_t might be the better option here.