Re: [PATCH 3/3] xfs: convert buf_cancel_table allocation to kmalloc_array

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, May 19, 2022 at 01:36:57AM -0700, Christoph Hellwig wrote:
> On Wed, May 18, 2022 at 11:55:40AM -0700, Darrick J. Wong wrote:
> > +	p = kmalloc_array(XLOG_BC_TABLE_SIZE, sizeof(struct list_head),
> > +			GFP_KERNEL | __GFP_NOWARN);
> 
> Why the __GFP_NOWARN?

It's a straight port of xfs_km_flags_t==0, which is what the old code
did.  I suspect it doesn't make any practical difference since at most
this will be allocating 1k of memory.  Want me to make it GFP_KERNEL
only?

--D



[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux