On Wed, May 18, 2022 at 11:55:29AM -0700, Darrick J. Wong wrote: > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > Move the code that allocates and frees the buffer cancellation tables > used by log recovery into the file that actually uses the tables. This > is a precursor to some cleanups and a memory leak fix. While you're at it, I'd also move XLOG_BC_TABLE_SIZE and XLOG_BUF_CANCEL_BUCKET to xfs_buf_item_recover.c. Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>